git_async_cat: don't use Gcf2 for temporary git dirs

We don't want to be holding references to temporary directories
longer than necessary, an Gcf is intended to be long-lived.

diff --git a/lib/PublicInbox/GitAsyncCat.pm b/lib/PublicInbox/GitAsyncCat.pm
index c12c4ec2528f750043e57abf660967d34e49e147..b32c2fd3cab4b6c665df483378b01f42952102c6 100644 (file)
--- a/lib/PublicInbox/GitAsyncCat.pm
+++ b/lib/PublicInbox/GitAsyncCat.pm
@@ -51,7 +51,8 @@ sub ibx_async_cat ($$$$) {
        # {topdir} means ExtSearch (likely [extindex "all"]) with potentially
        # 100K alternates.  git(1) has a proposed patch for 100K alternates:
        # <https://lore.kernel.org/git/20210624005806.12079-1-e@80x24.org/>
-       if (!defined($ibx->{topdir}) && ($GCF2C //= eval {
+       if (!defined($ibx->{topdir}) && !defined($git->{-tmp}) &&
+               ($GCF2C //= eval {
                require PublicInbox::Gcf2Client;
                PublicInbox::Gcf2Client::new();
        } // 0)) { # 0: do not retry if libgit2 or Inline::C are missing