clone: require `--objstore=' for default location

Allowing just `--objstore' without `=' was confusing,
since it could eat one of the required parameters (URL or
DESTINATION).

diff --git a/Documentation/public-inbox-clone.pod b/Documentation/public-inbox-clone.pod
index cee9f76eec04cf39868a9d1a6719ed784ff5fc86..257967d92809d6369817669c365294cb12067589 100644 (file)
--- a/Documentation/public-inbox-clone.pod
+++ b/Documentation/public-inbox-clone.pod
@@ -84,15 +84,15 @@ Force a remote public-inbox version (must be C<1> or C<2>).
 This is auto-detected by default, and this option exists mainly
 for testing.
 
-=item --objstore[=DIR]
+=item --objstore=DIR
 
 Enables space savings when the remote C<manifest.js.gz>
 includes C<forkgroup> entries as generated by grokmirror 2.x.
 
 If C<DIR> is not an absolute path, it is relative to the
-C<DESTINATION> directory.  If only C<--objstore> is specified
-without C<DIR>, then C<objstore> (C<$DESTINATION/objstore>)
-is the implied value of C<DIR>.
+C<DESTINATION> directory.  If only C<--objstore=> is specified
+where C<DIR> is an empty string (C<"">), then C<objstore>
+(C<$DESTINATION/objstore>) is the implied value of C<DIR>.
 
 =item -n
 

diff --git a/script/public-inbox-clone b/script/public-inbox-clone
index 26f42e74b8f82d2cfb9835df328bdcb1b1fe4979..e38d7b0d4afe0d445b7fc3fd91fe1ae529245c65 100755 (executable)
--- a/script/public-inbox-clone
+++ b/script/public-inbox-clone
@@ -13,7 +13,7 @@ usage: public-inbox-clone INBOX_URL [DESTINATION]
 options:
 
   --epoch=RANGE       range of v2 epochs to clone (e.g `2..5', `~0', `~1..')
-  --objstore [DIR]    share storage for coderepos
+  --objstore=DIR      share storage for coderepos
   --torsocks VAL      whether or not to wrap git and curl commands with
                       torsocks (default: `auto')
                       Must be one of: `auto', `no' or `yes'
@@ -23,7 +23,7 @@ options:
     -C DIR            chdir to specified directory
 EOF
 GetOptions($opt, qw(help|h quiet|q verbose|v+ C=s@ c=s@ include|I=s@ exclude=s@
-       inbox-config=s inbox-version=i objstore:s
+       inbox-config=s inbox-version=i objstore=s
        dry-run|n jobs|j=i no-torsocks torsocks=s epoch=s)) or die $help;
 if ($opt->{help}) { print $help; exit };
 require PublicInbox::Admin; # loads Config