nntpdeflate: reduce overhead of idle clients

We don't need to keep an empty buffer around in the common case
when a client is sending us completely inflatable requests and
we're able to read them in one go.

This only seems to save about 2M with 10K NNTPS clients using
COMPRESS, so it's not a huge win, but better than nothing.

diff --git a/lib/PublicInbox/NNTPdeflate.pm b/lib/PublicInbox/NNTPdeflate.pm
index f2de0f381c470f6b8c616aa43aff424fae2c65cc..c143488f14bd9010bb174bd7736194719f3f302e 100644 (file)
--- a/lib/PublicInbox/NNTPdeflate.pm
+++ b/lib/PublicInbox/NNTPdeflate.pm
@@ -56,7 +56,7 @@ sub enable {
        unlock_hash(%$self);
        $self->res('206 Compression active');
        bless $self, $class;
-       $self->{zin} = [ $in, '' ];
+       $self->{zin} = $in;
 }
 
 # overrides PublicInbox::NNTP::compressed
@@ -67,13 +67,16 @@ sub do_read ($$$$) {
        my ($self, $rbuf, $len, $off) = @_;
 
        my $zin = $self->{zin} or return; # closed
-       my $deflated = \($zin->[1]);
-       my $r = PublicInbox::DS::do_read($self, $deflated, $len) or return;
+       my $doff;
+       my $dbuf = delete($self->{dbuf}) // '';
+       $doff = length($dbuf);
+       my $r = PublicInbox::DS::do_read($self, \$dbuf, $len, $doff) or return;
 
        # assert(length($$rbuf) == $off) as far as NNTP.pm is concerned
-       # -ConsumeInput is true, so $deflated is automatically emptied
-       my $err = $zin->[0]->inflate($deflated, $rbuf);
+       # -ConsumeInput is true, so $dbuf is automatically emptied
+       my $err = $zin->inflate($dbuf, $rbuf);
        if ($err == Z_OK) {
+               $self->{dbuf} = $dbuf if $dbuf ne '';
                $r = length($$rbuf) and return $r;
                # nothing ready, yet, get more, later
                $self->requeue;