favor "--git-dir=..." over "--git-dir ..."

This might improve grep-ability slightly and reduce allocations
while we're at it.

diff --git a/lib/PublicInbox/GitCatFile.pm b/lib/PublicInbox/GitCatFile.pm
index bdad2b566770e56d616d4b31fc64cab2e46d28a1..b3d9bfb7e3152ae7e3479fce5a01480c8642fec6 100644 (file)
--- a/lib/PublicInbox/GitCatFile.pm
+++ b/lib/PublicInbox/GitCatFile.pm
@@ -17,8 +17,8 @@ sub _cat_file_begin {
        my ($self) = @_;
        return if $self->{pid};
        my ($in, $out);
-       my $pid = open2($in, $out, 'git', '--git-dir', $self->{git_dir},
-                       'cat-file', '--batch');
+       my $pid = open2($in, $out, 'git', "--git-dir=$self->{git_dir}",
+                       qw(cat-file --batch));
 
        $self->{pid} = $pid;
        $self->{in} = $in;

diff --git a/public-inbox.cgi b/public-inbox.cgi
index 6f20e1450b7393df1110259d82b3f5884d94638a..557d4923f2e5fa197059b1b59667c57a0865759a 100755 (executable)
--- a/public-inbox.cgi
+++ b/public-inbox.cgi
@@ -149,7 +149,7 @@ sub mid2blob {
        require IPC::Run;
        my ($in, $blob, $err);
        open my $null, '+<', '/dev/null' or die "open: $!\n";
-       IPC::Run::run(['git', '--git-dir', $ctx->{git_dir},
+       IPC::Run::run(['git', "--git-dir=$ctx->{git_dir}",
                        qw(cat-file blob), "HEAD:$1/$2"],
                        $null, \$blob, $null);
        $? == 0 ? \$blob : undef;