]> Sergey Matveev's repositories - public-inbox.git/log
public-inbox.git
9 years agopublic-inbox-init: manages the config files
Eric Wong [Sun, 21 Sep 2014 04:19:30 +0000 (04:19 +0000)]
public-inbox-init: manages the config files

This hopefully allows easier setup.

9 years agofilter: ensure CRs do not show up in lynx conversions
Eric Wong [Mon, 15 Sep 2014 20:58:41 +0000 (20:58 +0000)]
filter: ensure CRs do not show up in lynx conversions

Unix line endings are LF-only, so do not introduce or preserve
CRLF line endings when reading from lynx.

9 years agoindex: drop signatures from nested output
Eric Wong [Mon, 15 Sep 2014 20:47:33 +0000 (20:47 +0000)]
index: drop signatures from nested output

We have a less-ambiguous "more..." link nowadays if somebody
wants to see the full message.

9 years agohval: fixup bad line endings in HTML output
Eric Wong [Mon, 15 Sep 2014 20:47:02 +0000 (20:47 +0000)]
hval: fixup bad line endings in HTML output

We should do this in filter, too, but sometimes we
prefer to avoid filtering the message at all.

9 years agoindex: add prev/next index navigation
Eric Wong [Mon, 15 Sep 2014 04:16:45 +0000 (04:16 +0000)]
index: add prev/next index navigation

This helps readers jump around more quickly when there are
large messages.

9 years agoindex group state parameters together for generation
Eric Wong [Mon, 15 Sep 2014 03:17:29 +0000 (03:17 +0000)]
index group state parameters together for generation

This allows us to more-easily group and pass parameters.

9 years agoview: standalone view shows link to index
Eric Wong [Mon, 15 Sep 2014 03:00:49 +0000 (03:00 +0000)]
view: standalone view shows link to index

Sometimes people come from sharing links and not the index,
so the back button in their browser does not really go back.

9 years agoview: kill unnecessary assignment
Eric Wong [Mon, 15 Sep 2014 02:49:18 +0000 (02:49 +0000)]
view: kill unnecessary assignment

Not sure what I was thinking

9 years agoview: support SHA-1 of Message-IDs for message links
Eric Wong [Mon, 15 Sep 2014 02:34:33 +0000 (02:34 +0000)]
view: support SHA-1 of Message-IDs for message links

Some Message-IDs are crazy long, so support SHA-1s for them
instead.  This allows shorter URLs to be generated and are
less likely

However, we'll still favor short Message-IDs whenever possible.

9 years agoindex: show short-ish permalinks to messages in threads
Eric Wong [Sun, 14 Sep 2014 23:06:11 +0000 (23:06 +0000)]
index: show short-ish permalinks to messages in threads

This should allow us to reference discussions more easily.

9 years agoline-wrap generated HTML source around attrs for readability
Eric Wong [Sat, 13 Sep 2014 21:50:31 +0000 (21:50 +0000)]
line-wrap generated HTML source around attrs for readability

It's important to keep HTML source readable to folks who prefer
to read raw HTML.  This should improve readability of the HTML
source by keeping line length in check without wasting bytes.

9 years agofeed: (cleanup) avoid redundant ->message call
Eric Wong [Sun, 7 Sep 2014 22:56:09 +0000 (22:56 +0000)]
feed: (cleanup) avoid redundant ->message call

Avoid redundant subroutine calls as their costs tend to add up.

9 years agofeed: sort child messages (forward) chronologically
Eric Wong [Sun, 7 Sep 2014 22:53:15 +0000 (22:53 +0000)]
feed: sort child messages (forward) chronologically

Only root messages should be sorted in reverse chronological order,
child messages should be chronological.  This gives precedence to
_topics_, but also for initial replies.

This improves readability when several messages appear at the same
nesting level, and helps git patch series' appear correctly as:

[PATCH 0/3] ...
[PATCH 1/3] ...
[PATCH 2/3] ...
[PATCH 3/3] ...

Instead of (what it was previously):

[PATCH 0/3] ...
[PATCH 3/3] ...
[PATCH 2/3] ...
[PATCH 1/3] ...

9 years agoview: fixup dropped newline in the last commit
Eric Wong [Sun, 7 Sep 2014 07:56:42 +0000 (07:56 +0000)]
view: fixup dropped newline in the last commit

Oops!

9 years agoview: avoid extraneous space for subject-only messages
Eric Wong [Sun, 7 Sep 2014 07:53:47 +0000 (07:53 +0000)]
view: avoid extraneous space for subject-only messages

Sometimes, the subject says it all.

9 years agoview: reduce redundant linkage in index
Eric Wong [Sat, 6 Sep 2014 23:31:40 +0000 (23:31 +0000)]
view: reduce redundant linkage in index

There's no point in having a "(more...)" and "link" pointing
to the same element, replace "link" with "more..." if we've
omitted text from the index.

9 years agoview: increase context in index views
Eric Wong [Wed, 3 Sep 2014 20:43:33 +0000 (20:43 +0000)]
view: increase context in index views

It's probably better to show too much than too little, even
if this means extra scrolling :<

Otherwise, we end up punishing messages who quote minimally
and end up loosing context.  Unfortunately, too many people
over-quote nowadays.

9 years agoview: kill leading whitespace in index
Eric Wong [Sun, 31 Aug 2014 02:58:07 +0000 (02:58 +0000)]
view: kill leading whitespace in index

Leading whitespace is pointless, but some folks end up adding
it for some reason.

9 years agoview: show quotes in index if parent is too old
Eric Wong [Sun, 31 Aug 2014 02:52:27 +0000 (02:52 +0000)]
view: show quotes in index if parent is too old

It's helpful to show context if a message does not
appear on the current index page.

9 years agoview: tighten up regexps used for trimming index
Eric Wong [Thu, 28 Aug 2014 05:06:41 +0000 (05:06 +0000)]
view: tighten up regexps used for trimming index

The previous regexp matches were too aggressive w.r.t.  scissors.
We destroy trailing whitespace anyways, so do not worry about it
when cutting signatures and patches off.

9 years agoview: trim git patches delimited by /^---$/
Eric Wong [Thu, 28 Aug 2014 04:57:30 +0000 (04:57 +0000)]
view: trim git patches delimited by /^---$/

Patches are usually better viewed standalone and are difficult
to judge when nested.  So save precious vertical space in our
message index.

9 years agofeed: deal with removed files
Eric Wong [Thu, 28 Aug 2014 02:15:08 +0000 (02:15 +0000)]
feed: deal with removed files

Sometimes we get spam and need to delete messages,
we must prevent errors on missing messages from propagating.

9 years agofeed: show permalink to home page
Eric Wong [Thu, 28 Aug 2014 02:14:47 +0000 (02:14 +0000)]
feed: show permalink to home page

This will make it easier to bookmark an index page with threading
context.

9 years agoview: increase MAX_INLINE_QUOTED threshold to 12
Eric Wong [Thu, 28 Aug 2014 01:33:43 +0000 (01:33 +0000)]
view: increase MAX_INLINE_QUOTED threshold to 12

12 lines is half an 80x24 terminal, so it is probably a reasonable
amount to quote.  Often 5 lines was not enough for context.  This
feature is mainly to reduce scrolling necessary to view pages.

9 years agoredo main HTML index to show nested messages
Eric Wong [Thu, 28 Aug 2014 01:25:12 +0000 (01:25 +0000)]
redo main HTML index to show nested messages

This reduces the need for page reloads in common cases and should
improve reading speed so users do not need to open many browser
tabs.  This will hopefully increase an encourage readership.

The downside of this are increased server processing overhead and
easier address scraping by spam bots.

9 years agoview: Email::Address cache purge is optional
Eric Wong [Wed, 27 Aug 2014 19:34:03 +0000 (19:34 +0000)]
view: Email::Address cache purge is optional

We will reuse the html_footer function in a nested index.

9 years agoshow date in top-level threaded index
Eric Wong [Tue, 26 Aug 2014 05:46:15 +0000 (05:46 +0000)]
show date in top-level threaded index

This is probably useful information for folks browsing via web
interface.  It'll probably make more sense if we show the entire
body in the threaded display, though.

9 years agot/view: ensure HTML shows QP text
Eric Wong [Mon, 4 Aug 2014 20:24:14 +0000 (20:24 +0000)]
t/view: ensure HTML shows QP text

We need to ensure the HTML output is not mangled, either.

9 years agofilter: preserve QP when collapsing multipart
Eric Wong [Mon, 4 Aug 2014 20:16:51 +0000 (20:16 +0000)]
filter: preserve QP when collapsing multipart

HTML clients also tend to send quoted-printable crap in
their plain-text parts, preserve that so it's displayed
correctly for all QP-capable handlers.

9 years agodoc/dc-dlvr-spam-flow: link to ssoma, too
Eric Wong [Wed, 2 Jul 2014 19:50:28 +0000 (19:50 +0000)]
doc/dc-dlvr-spam-flow: link to ssoma, too

Some readers may not be familiar with ssoma internals such as
ssoma-rm.

9 years agodoc/dc-dlvr-spam-flow: include links to relevant projects
Eric Wong [Wed, 2 Jul 2014 19:46:57 +0000 (19:46 +0000)]
doc/dc-dlvr-spam-flow: include links to relevant projects

Some of these projects are not well known, so link to them
to help new users.

9 years agodoc: remove HTML
Eric Wong [Wed, 2 Jul 2014 19:33:33 +0000 (19:33 +0000)]
doc: remove HTML

Even with txt2pre, the maintenance/discoverability burden is too
high and lynx still uses too much memory.  Unfortunately, we'll have
to keep our INSTALL.html for a while longer on the server since it's
linked, but not index.html!

9 years agot/html_index.t: fix warnings in test case
Eric Wong [Sat, 28 Jun 2014 01:06:31 +0000 (01:06 +0000)]
t/html_index.t: fix warnings in test case

Oops.

9 years agoREADME: reflow and expand initial introduction a bit
Eric Wong [Fri, 30 May 2014 06:51:49 +0000 (06:51 +0000)]
README: reflow and expand initial introduction a bit

Marketing is hard!

9 years agosa_config: just put HTML messages in the mod queue
Eric Wong [Tue, 27 May 2014 08:30:44 +0000 (08:30 +0000)]
sa_config: just put HTML messages in the mod queue

We can be stricter about HTML email, since none of the lists
hosted here accept HTML.

9 years agospamassassin/user_prefs: do not favor paid whitelist services
Eric Wong [Fri, 23 May 2014 09:56:02 +0000 (09:56 +0000)]
spamassassin/user_prefs: do not favor paid whitelist services

Paid reputation management services are not encouraged.

9 years agospamassassin/user_prefs: disable non-English
Eric Wong [Fri, 23 May 2014 09:54:38 +0000 (09:54 +0000)]
spamassassin/user_prefs: disable non-English

Too much spam arrives without any readable English, and I (the
server administrator) cannot easily tell if a non-English
message is spam or not.

9 years agoslrnspool2maildir: fix help and dir creation
Eric Wong [Thu, 8 May 2014 22:32:13 +0000 (22:32 +0000)]
slrnspool2maildir: fix help and dir creation

Any existing directory should do.

9 years agoMDA: cleanse headers in case of delivery
Eric Wong [Wed, 21 May 2014 15:22:49 +0000 (15:22 +0000)]
MDA: cleanse headers in case of delivery

We nuke DKIM headers because we modify headers and sometimes the
body, which may invalidate the message.  We'll also nuke whatever
Mailman nukes from messages to avoid phishing and leaking
information.

9 years agomda: drop RFC2369 support for now
Eric Wong [Thu, 8 May 2014 02:19:00 +0000 (02:19 +0000)]
mda: drop RFC2369 support for now

That should be use down stream by delivery agents.

9 years agowww: attempt to improve formatting of footer
Eric Wong [Wed, 7 May 2014 01:43:09 +0000 (01:43 +0000)]
www: attempt to improve formatting of footer

This looks nicer to me (totally subjective and open to bikeshedding
:P)

9 years agoconsistently whitespace wrap on <pre> sections
Eric Wong [Tue, 6 May 2014 19:44:43 +0000 (19:44 +0000)]
consistently whitespace wrap on <pre> sections

Horizontal scrolling is a usability problem for GUI browsers,
so help them avoid it.  I love GUI users, really! :)

9 years agoINSTALL: update support status
Eric Wong [Tue, 6 May 2014 19:30:32 +0000 (19:30 +0000)]
INSTALL: update support status

We probably won't bother with FastCGI until there is interest.

9 years agoexamples/apache2_perl.conf: set PI_CONFIG
Eric Wong [Mon, 5 May 2014 19:59:56 +0000 (19:59 +0000)]
examples/apache2_perl.conf: set PI_CONFIG

This is easier and lower-impact than setting HOME anywhere.

9 years agowww: set charset=UTF-8 in full message view
Eric Wong [Mon, 5 May 2014 19:56:20 +0000 (19:56 +0000)]
www: set charset=UTF-8 in full message view

Oops, this was an oversight.

9 years agolearn: set_list_headers on training
Eric Wong [Mon, 5 May 2014 08:48:13 +0000 (08:48 +0000)]
learn: set_list_headers on training

This is idempotent, and should actually/really prevent training
loops.

9 years agomda: attempt to prevent training loops
Eric Wong [Mon, 5 May 2014 08:39:14 +0000 (08:39 +0000)]
mda: attempt to prevent training loops

9 years agofeed: add atom feed link to the bottom
Eric Wong [Mon, 5 May 2014 01:07:54 +0000 (01:07 +0000)]
feed: add atom feed link to the bottom

This should improve navigation as browsers may not make it
obvious there is an Atom feed.

9 years agoview: add newline before list-wide footer
Eric Wong [Mon, 5 May 2014 01:01:13 +0000 (01:01 +0000)]
view: add newline before list-wide footer

Otherwise the reply link gets squished.

9 years agowww: multi-line cloneurl maps to multiple lines
Eric Wong [Mon, 5 May 2014 00:57:06 +0000 (00:57 +0000)]
www: multi-line cloneurl maps to multiple lines

URLs may be long, so give each its own line.

9 years agowww: add footers to HTML index and message views
Eric Wong [Mon, 5 May 2014 00:47:41 +0000 (00:47 +0000)]
www: add footers to HTML index and message views

Some advertising is necessary.

9 years agoadd various TODO items
Eric Wong [Sun, 4 May 2014 01:38:16 +0000 (01:38 +0000)]
add various TODO items

Screen space is precious, and we do not need it in the abbreviated
view.

9 years agoview: API cleanup, remove "as_" prefix
Eric Wong [Fri, 2 May 2014 23:16:37 +0000 (23:16 +0000)]
view: API cleanup, remove "as_" prefix

These views are not OO, so the "as_" prefix makes little sense
and "as_html" conflicts with Hval, which is OO.

9 years agoreduce copies by passing string refs to Email::MIME
Eric Wong [Fri, 2 May 2014 20:28:43 +0000 (20:28 +0000)]
reduce copies by passing string refs to Email::MIME

This should reduce data copies and memory usage, according
to Email::Simple documentation.

9 years agogit cat-file wrapper uses syswrite for writes
Eric Wong [Fri, 2 May 2014 20:07:59 +0000 (20:07 +0000)]
git cat-file wrapper uses syswrite for writes

The requests we make to git cat-file --batch are guaranteed to be
smaller than the 512 bytes required by PIPE_BUF, so there will be no
partial writes.  Bypass Perl IO layers and write directly to the
pipe to avoid needing IO::Handle here.

10 years agothread: limit scope of monkey patch
Eric Wong [Thu, 1 May 2014 18:33:18 +0000 (18:33 +0000)]
thread: limit scope of monkey patch

Future versions of Mail::Thread may be released to fix this bug.
However, since it's been about 8 years since the bug was reported..

10 years agoworkaround Mail::Thread memory leak
Eric Wong [Thu, 1 May 2014 02:30:00 +0000 (02:30 +0000)]
workaround Mail::Thread memory leak

Thanks to Ask for the patch in
https://rt.cpan.org/Public/Bug/Display.html?id=22817

10 years agopurge Email::Address cache
Eric Wong [Thu, 1 May 2014 01:56:34 +0000 (01:56 +0000)]
purge Email::Address cache

This prevents memory bloat in case we're serving many requests
with a large, diverse set of email addresses (potentially from
malicious spammers).

10 years agosplit out WWW package and CGI/PSGI-specific parts
Eric Wong [Wed, 30 Apr 2014 22:58:23 +0000 (22:58 +0000)]
split out WWW package and CGI/PSGI-specific parts

This should allow us to more-easily test with Plack.

10 years agoexamples: make web configs consistent and add README
Eric Wong [Wed, 30 Apr 2014 22:04:44 +0000 (22:04 +0000)]
examples: make web configs consistent and add README

Hopefully this is enough to get some folks started.

10 years agocgi: set charset in responses
Eric Wong [Wed, 30 Apr 2014 21:39:24 +0000 (21:39 +0000)]
cgi: set charset in responses

This ought to prevent browsers from misguessing/misdetecting
things.

10 years agoadd example configs for Apache2 mod_perl and CGI
Eric Wong [Wed, 30 Apr 2014 20:24:54 +0000 (20:24 +0000)]
add example configs for Apache2 mod_perl and CGI

These are probably still popular configurations in some
settings, so include sample configurations to get folks
started.  These are trickier than an average CGI script
to setup because we rely on pretty URLs from PATH_INFO
and not ugly query parameters.

10 years ago"git cat-file --batch" wrapper really mod_perl-compatible
Eric Wong [Wed, 30 Apr 2014 20:13:54 +0000 (20:13 +0000)]
"git cat-file --batch" wrapper really mod_perl-compatible

IPC::Open* does not work well under mod_perl (probably because
it does funky things with stdout/stderr).  So use the POSIX
dup2 functions instead, which work reliably on all POSIX-like
platforms.

10 years agocgi: avoid warning after exec
Eric Wong [Wed, 30 Apr 2014 19:17:21 +0000 (19:17 +0000)]
cgi: avoid warning after exec

Found with mod_perl2 (as it overrides exit).

10 years agocgi: remove dependency on IPC::Run in CGI
Eric Wong [Wed, 30 Apr 2014 01:03:30 +0000 (01:03 +0000)]
cgi: remove dependency on IPC::Run in CGI

We may not have PATH available on some servers (e.g. webrick)
and must rely on the hardcoded system PATH.  My installation of
IPC::Run does not seem to work without PATH set in the env,
however normal Perl "open" calls work fine.

10 years agoconfig: avoid double-slash in expand_path output
Eric Wong [Wed, 30 Apr 2014 01:02:53 +0000 (01:02 +0000)]
config: avoid double-slash in expand_path output

It looks ugly in error messages to have redundant slashes.

10 years agocgi: disable warnings for CGI::NOSTICKY
Eric Wong [Wed, 30 Apr 2014 00:19:48 +0000 (00:19 +0000)]
cgi: disable warnings for CGI::NOSTICKY

We probably know what we're doing, here...

10 years agofavor "--git-dir=..." over "--git-dir ..."
Eric Wong [Wed, 30 Apr 2014 00:16:55 +0000 (00:16 +0000)]
favor "--git-dir=..." over "--git-dir ..."

This might improve grep-ability slightly and reduce allocations
while we're at it.

10 years agofeed: unset GIT_DIR and use "git --git-dir=.. log"
Eric Wong [Wed, 30 Apr 2014 00:14:35 +0000 (00:14 +0000)]
feed: unset GIT_DIR and use "git --git-dir=.. log"

This should elimate all of our %ENV dependencies in the WWW portion
of our code.

10 years agocgi: mid2blob does not depend on $ENV{GIT_DIR}
Eric Wong [Tue, 29 Apr 2014 05:33:45 +0000 (05:33 +0000)]
cgi: mid2blob does not depend on $ENV{GIT_DIR}

ENV changes do not propagate to child processes under mod_perl

10 years agoimplement our own cat-file --batch wrapper
Eric Wong [Tue, 29 Apr 2014 05:10:48 +0000 (05:10 +0000)]
implement our own cat-file --batch wrapper

We use --git-dir=... instead of $ENV{GIT_DIR} because ENV changes
do not propagate easily with mod_perl.

10 years agoconfig: use "git config --file" to avoid changing %ENV
Eric Wong [Tue, 29 Apr 2014 03:43:20 +0000 (03:43 +0000)]
config: use "git config --file" to avoid changing %ENV

%ENV changes do not propagate by default under a mod_perl2
environment, and we might as well work towards being thread-safe.

10 years agocgi: make CGI optional for Plack users
Eric Wong [Mon, 28 Apr 2014 22:09:30 +0000 (22:09 +0000)]
cgi: make CGI optional for Plack users

CGI.pm is on its way out, so do not make it a hard requirement for
Plack users.  We still support CGI-only installations because some
sysadmins and distros may be very conservative.

10 years agocgi: wrap self_uri calls for Plack::Request
Eric Wong [Mon, 28 Apr 2014 21:46:44 +0000 (21:46 +0000)]
cgi: wrap self_uri calls for Plack::Request

We should be adding automated tests for this, soon.

10 years agofeed: call URI->as_string explicitly
Eric Wong [Mon, 28 Apr 2014 21:46:04 +0000 (21:46 +0000)]
feed: call URI->as_string explicitly

Implicit string conversion is more confusing.

10 years agouse relative URLs in HTML index
Eric Wong [Mon, 28 Apr 2014 21:02:41 +0000 (21:02 +0000)]
use relative URLs in HTML index

Browsers know how to follow relative URLs, so we may generate
smaller HTML pages.

10 years agocgi: do not decode path_info
Eric Wong [Mon, 28 Apr 2014 20:47:33 +0000 (20:47 +0000)]
cgi: do not decode path_info

We only generate URI-escaped URLs, so we should not be decoding this
into octets.

10 years agofeed: swap order of "next" and "head" links
Eric Wong [Mon, 28 Apr 2014 20:45:42 +0000 (20:45 +0000)]
feed: swap order of "next" and "head" links

This is one less key stroke for somebody paging through the
list history.

10 years agofeed: avoid redirect on permalink
Eric Wong [Mon, 28 Apr 2014 20:04:44 +0000 (20:04 +0000)]
feed: avoid redirect on permalink

This saves one round-trip request response so reduces latency over
slow links.  The redirect only exists for convenience and isn't 100%
reliable in case the Message-ID terminates with a .(html|txt)
suffix.

10 years agofeed: dead code elimination around dropped endpoints
Eric Wong [Mon, 28 Apr 2014 10:55:59 +0000 (10:55 +0000)]
feed: dead code elimination around dropped endpoints

public-inbox is for discussion, so top-level posts do not get
special treatment.

10 years agomda: support aliased addresses
Eric Wong [Mon, 28 Apr 2014 10:25:58 +0000 (10:25 +0000)]
mda: support aliased addresses

This mimics functionality found in -learn.  Originally the design
allowed for only one address per-list, but when migrating/hijacking
existing mailing lists, having multiple addresses map to the same
inbox is useful.

10 years agofeed: disable navigation to previous page
Eric Wong [Mon, 28 Apr 2014 07:39:41 +0000 (07:39 +0000)]
feed: disable navigation to previous page

This is unfortunately needed for scalability to long histories.
The design of git requires it to traverse full history to walk
forward in time, since commits can only record past history.

Instead, replace "prev" with a "head" link to zip us back to
the most recent page.  Users who wish to go backwards can use
browser history, which should always work on our old-fashioned
HTML pages.

10 years agofeed: pedantically quote HTML attributes
Eric Wong [Mon, 28 Apr 2014 03:27:21 +0000 (03:27 +0000)]
feed: pedantically quote HTML attributes

This is more correct, although it costs us 4 bytes.

10 years agoallow running as a Plack app without CGI emulation
Eric Wong [Mon, 28 Apr 2014 04:56:47 +0000 (04:56 +0000)]
allow running as a Plack app without CGI emulation

This might be slightly cleaner, though generating the base URL
now has an ugly condition in it.

10 years agouri_escape => uri_escape_utf8
Eric Wong [Mon, 28 Apr 2014 04:50:17 +0000 (04:50 +0000)]
uri_escape => uri_escape_utf8

We should be able to deal with URIs with non-ASCII characters in
them.  I only found this problem when looking at archives with
non-English spam :x

10 years agocgi: preliminary Plack compatibility
Eric Wong [Mon, 28 Apr 2014 02:15:04 +0000 (02:15 +0000)]
cgi: preliminary Plack compatibility

This needs further testing and refactoring, but seems to work
reasonably well.

10 years agofeeds use XHTML to avoid tag soup
Eric Wong [Sun, 27 Apr 2014 06:21:57 +0000 (06:21 +0000)]
feeds use XHTML to avoid tag soup

This should work in most browsers, lets find out!

10 years agoFeed: <id> element must be a URI, oops :x
Eric Wong [Sun, 27 Apr 2014 05:04:02 +0000 (05:04 +0000)]
Feed: <id> element must be a URI, oops :x

For each feed element, we'll just use the link since there's
currently no suitable URN.

10 years agoview: uri_escape subject
Eric Wong [Sun, 27 Apr 2014 01:56:39 +0000 (01:56 +0000)]
view: uri_escape subject

This hopefully improves compatibility with mailers

10 years agofeed: comment about the %deleted hash
Eric Wong [Sat, 26 Apr 2014 22:22:35 +0000 (22:22 +0000)]
feed: comment about the %deleted hash

It's strictly not necessary anymore since
commit fa6168c56bdd1cece178b6b852a9b2cba6ce6ffb
("feed: message must exist in current HEAD to show up")

However it can still save us some unnecessary syscalls and
round-trips to the "git cat-file --batch" process, so it's probably
worth th cost of stuffing it in a hash.

10 years agocgi: style: return undef => return
Eric Wong [Sat, 26 Apr 2014 21:32:52 +0000 (21:32 +0000)]
cgi: style: return undef => return

10 years agofeed: message must exist in current HEAD to show up
Eric Wong [Sat, 26 Apr 2014 09:07:42 +0000 (09:07 +0000)]
feed: message must exist in current HEAD to show up

We do not want recently-deleted spam showing up when looking
in old histories.

10 years agospamassassin rule and config updates
Eric Wong [Sat, 26 Apr 2014 07:42:25 +0000 (07:42 +0000)]
spamassassin rule and config updates

While we're at it, add a script for easy editing of user prefs.
We need some human-maintained rules based on the spam we get.
It's an imperfect world, but I'd _much_ rather deal with the
occassional spam than require signup/registration to post.

10 years agoview: show References: header, too
Eric Wong [Sat, 26 Apr 2014 02:52:50 +0000 (02:52 +0000)]
view: show References: header, too

Some mail user agents use this header, and Mail::Thread uses
it, too, so show it if possible, but only if it's not redundant
to In-Reply-To.

10 years agoview: add per-message HTML footer to encourage replies
Eric Wong [Sat, 26 Apr 2014 02:29:22 +0000 (02:29 +0000)]
view: add per-message HTML footer to encourage replies

This may not work with most mail user agents, however.

10 years agohuge refactor of encoding handling
Eric Wong [Sat, 26 Apr 2014 01:01:10 +0000 (01:01 +0000)]
huge refactor of encoding handling

Hopefully this simplifies and corrects our usage of Perl encoding
APIs.

10 years agocgi: eliminate dead/redundant HTML escaping code
Eric Wong [Fri, 25 Apr 2014 07:49:14 +0000 (07:49 +0000)]
cgi: eliminate dead/redundant HTML escaping code

10 years agohtml: refactor header value handling to be OO
Eric Wong [Thu, 24 Apr 2014 00:21:21 +0000 (00:21 +0000)]
html: refactor header value handling to be OO

This helps us keep track of escaping which needs to be done
for various levels.

10 years agot/feed: cleanup test and add test for /f/ link
Eric Wong [Wed, 23 Apr 2014 10:50:08 +0000 (10:50 +0000)]
t/feed: cleanup test and add test for /f/ link

We already depend on IPC::Run, so just use it our tests.

10 years agofeed: add tests for <id> element setting
Eric Wong [Wed, 23 Apr 2014 01:05:56 +0000 (01:05 +0000)]
feed: add tests for <id> element setting

We need to ensure this works

This follows commit bd8fd095067b79a0d2a40bbca2b27b923d02b3f8
("feed: fix address when multiple addresses exist")